-
Notifications
You must be signed in to change notification settings - Fork 58
Add Flux specifications to path/bstr/hash/time #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given I'm not intimately familiar with Flux some of the annotations introduced in this PR are not entirely clear to me, see detailed comments. Please include some comments. Thank you!
dc3829c
to
242f5f7
Compare
a6a7882
to
d3ba4eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Head branch was pushed to by a user without write access
d3ba4eb
to
ac0ece6
Compare
ac0ece6
to
0375ccd
Compare
@tautschnig, sorry for the delay, but Flux is green again! After the toolchain update, we had to add a couple of extra specs included in 0375ccd |
This PR adds flux specifications for checking the following modules in core
In particular, it verifies that
Nanoseconds
is correctly used with values within the range.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.